-
Notifications
You must be signed in to change notification settings - Fork 1.9k
【PaddleSpeech No.13、14】补全合成系列中的脚本中参数缺失 #4013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! |
@zxcd pls review |
examples/vctk/ernie_sat/run.sh
Outdated
@@ -27,10 +27,11 @@ if [ ${stage} -le 1 ] && [ ${stop_stage} -ge 1 ]; then | |||
fi | |||
|
|||
if [ ${stage} -le 2 ] && [ ${stop_stage} -ge 2 ]; then | |||
# synthesize, vocoder is pwgan | |||
CUDA_VISIBLE_DEVICES=${gpus} ./local/synthesize.sh ${conf_path} ${train_output_path} ${ckpt_name} || exit -1 | |||
# synthesize, vocoder is hifigan by default stage 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only stage 0 support does not need to be written.
examples/vctk/ernie_sat/run.sh
Outdated
fi | ||
|
||
if [ ${stage} -le 3 ] && [ ${stop_stage} -ge 3 ]; then | ||
CUDA_VISIBLE_DEVICES=${gpus} ./local/synthesize_e2e.sh ${conf_path} ${train_output_path} ${ckpt_name} || exit -1 | ||
# synthesize, vocoder is pwgan by default stage 0, stage 1 will use hifigan as vocoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stage control task_name
, not vocoder
. Follow code examples/vctk/ernie_sat/local/synthesize_e2e.sh
``` | ||
`--stage` controls the vocoder model during synthesis, which can be `0` or `1`, use `pwgan` or `hifigan` model as vocoder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add this line in synthesize_e2e.sh
in below
examples/vctk/tts3/run.sh
Outdated
@@ -27,12 +27,12 @@ if [ ${stage} -le 1 ] && [ ${stop_stage} -ge 1 ]; then | |||
fi | |||
|
|||
if [ ${stage} -le 2 ] && [ ${stop_stage} -ge 2 ]; then | |||
# synthesize, vocoder is pwgan by default | |||
# synthesize, vocoder is pwgan by default stage 0, stage 1 will use hifigan as vocoder | |||
CUDA_VISIBLE_DEVICES=${gpus} ./local/synthesize.sh ${conf_path} ${train_output_path} ${ckpt_name} || exit -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miss --stage 0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Function optimization, Docs
PR changes
Docs, Others
Describe
本次修改主要包含:
修改examples/vctk/tts3和examples/vctk/ernie_sat
脚本优化: 为 run.sh 中的合成阶段添加 --stage 参数,支持通过0/1选择 PWGAN/HiFiGAN 作为声码器;在 synthesize.sh 和 synthesize_e2e.sh 中实现多声码器切换逻辑
文档完善: 在 README.md 中补充 stage 参数说明,明确 vocoder 选择逻辑。
Issue链接:#3997
@luotao1 @zxcd