【PaddleSpeech No.5】补全合成系列中的脚本中参数缺失 #4005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zxcd
reviewed
Mar 18, 2025
| @@ -27,10 +27,11 @@ if [ ${stage} -le 1 ] && [ ${stop_stage} -ge 1 ]; then | |||
| fi | |||
|
|
|||
| if [ ${stage} -le 2 ] && [ ${stop_stage} -ge 2 ]; then | |||
| # synthesize, vocoder is pwgan | |||
| CUDA_VISIBLE_DEVICES=${gpus} ./local/synthesize.sh ${conf_path} ${train_output_path} ${ckpt_name} || exit -1 | |||
| # synthesize, vocoder is pwgan by default stage 0, stage 1 will use hifigan as vocoder | |||
There was a problem hiding this comment.
synthesize.sh only has stage 0, no need to change this?
zxcd
reviewed
Mar 18, 2025
| fi | ||
|
|
||
| if [ ${stage} -le 3 ] && [ ${stop_stage} -ge 3 ]; then | ||
| CUDA_VISIBLE_DEVICES=${gpus} ./local/synthesize_e2e.sh ${conf_path} ${train_output_path} ${ckpt_name} || exit -1 | ||
| # synthesize_e2e, vocoder is pwgan by default stage 0, stage 1 will use hifigan as vocoder |
There was a problem hiding this comment.
stage 0 and stage 1 all use hifigan. The stage distinction should not be based on the vocoder.
|
This reverts commit 076134a.
CI done |
|
评审人的每个意见都要回复，其他PR同 |
zxcd
reviewed
Mar 25, 2025
| ``` | ||
| `--stage` controls the vocoder model during synthesis, which can be `0` or `1`, use `pwgan` or `hifigan` model as vocoder. |
There was a problem hiding this comment.
take a look at ./local/synthesize.sh, there are four stages.
|
close due to the following PR is merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Docs
Describe
补全合成系列中的脚本中参数缺失 No.5
修改：
examples/aishell3_vctk/ernie_sat/run.shexamples/aishell3_vctk/ernie_sat/README.md