Skip to content

Conversation

Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Feb 9, 2022

PR types

Others

PR changes

Others

Describe

主要工作:

  • proto::VarType 从Pten中迁移出去,实现与Pten解耦
  • convert_utils.cc迁移到fluid目录下,并将TransToProtoTypeTransToPtenType一并迁移
  • 将fluid目录下所有涉及到Proto::VarType的接口调用调整为TransToProtoType
  • 初步统一DenseTensor中的type()dtype接口,为后续移除type()+saved_type()接口做准备

贡献RD: @2742195759

@PaddlePaddle PaddlePaddle deleted a comment from paddle-bot-old bot Feb 10, 2022
chenwhql
chenwhql previously approved these changes Feb 11, 2022
@Aurelius84 Aurelius84 requested a review from chenwhql February 11, 2022 10:35
chenwhql
chenwhql previously approved these changes Feb 11, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark

@Aurelius84 Aurelius84 merged commit 7e7e940 into PaddlePaddle:develop Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants