Skip to content

refine matrix_rank op #35722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2021
Merged

refine matrix_rank op #35722

merged 2 commits into from
Sep 17, 2021

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Sep 14, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

refine matrix_rank op
修改的内容包括：

  1. 修改含义不明的函数名称
  2. 合并多余的if-else分支
  3. 修改英文文档的格式，增加对hermitian说明
  4. 统一参数命名规范
    image
    image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Aurelius84
Aurelius84 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhhsplendid
zhhsplendid approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 28fffef into PaddlePaddle:develop Sep 17, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@0x45f @AnnaTrainingG
refine matrix_rank op code and doc (PaddlePaddle#35722)
11f1670
@0x45f 0x45f deleted the refine_matrix_rank_op branch October 12, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x45f @zhhsplendid @Aurelius84 @TCChenlong