Skip to content

将signal.stft的onsided的默认参数值从True改为None #73420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2025
Merged

将signal.stft的onsided的默认参数值从True改为None #73420

merged 2 commits into from
Jun 19, 2025

Conversation

Qin-sx
Copy link
Contributor

@Qin-sx Qin-sx commented Jun 18, 2025

PR Category

User Experience

PR Types

Improvements

Description

默认值改为None，会自动根据输入判断是否返回一半的频点值。当输入为复数时，不需要每次手动输入onsided=False。

相关pytorch代码：

  const bool complex_fft = input.is_complex();
  const auto onesided = onesidedOpt.value_or(!complex_fft);

Qin-sx added 2 commits June 18, 2025 09:55
@Qin-sx
changed default onsided from True to None
3460942 
	modified:   python/paddle/signal.py
@Qin-sx
updated x
e0ce421 
	modified:   python/paddle/signal.py
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jun 18, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 18, 2025
@Qin-sx
Copy link
Contributor Author

Qin-sx commented Jun 18, 2025 •
edited
Loading

pytorch后续会弃用return_complex=False。return_complex默认值为None。

From version 1.8.0, return_complex must always be given explicitly for real inputs and return_complex=False has been deprecated. Strongly prefer return_complex=True as in a future pytorch release, this function will only return complex tensors.

zhwesky2010
zhwesky2010 approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 17ab92c into PaddlePaddle:develop Jun 19, 2025
47 of 50 checks passed
This was referenced Jun 20, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

@luotao1 luotao1

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qin-sx @zhwesky2010 @luotao1