Skip to content

[Accuracy diff No.42、118] Fix accuracy diff for paddle.nn.functional.embedding API #73445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Accuracy diff No.42、118] Fix accuracy diff for paddle.nn.functional.embedding API #73445

wants to merge 6 commits into from

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Jun 18, 2025 •
edited
Loading

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

Pytorch 中 padding_idx 并不会导致前向输出为 0，会保持为原来的 weight，只是反向不会贡献对应 weight 的梯度，所以前向 kernel 不需要考虑 padding_idx 的值
https://docs.pytorch.org/docs/stable/generated/torch.nn.functional.embedding.html
https://github.com/pytorch/pytorch/blob/6959b5febe090375e261e678902681533d2e2528/aten/src/ATen/native/Embedding.cpp#L37-L55

PaddleAPITest 测试通过
图片

TODO

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jun 18, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 18, 2025
@ooooo-create ooooo-create mentioned this pull request Jun 19, 2025
Open
@ooooo-create ooooo-create marked this pull request as ready for review June 19, 2025 00:56
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Jun 19, 2025
@luotao1 luotao1 mentioned this pull request Jun 19, 2025
Open
@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@ooooo-create ooooo-create changed the title [Accuracy diff No.118] Fix accuracy diff for paddle.nn.functional.embedding API [Accuracy diff No.42、118] Fix accuracy diff for paddle.nn.functional.embedding API Jun 19, 2025
@ooooo-create ooooo-create force-pushed the accuracy_embedding branch 3 times, most recently from c49ca5f to 91df9aa Compare June 21, 2025 13:11
@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@0f3860d). Learn more about missing BASE report.

Additional details and impacted files 
@@             Coverage Diff             @@
##             develop    #73445   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         5           
  Branches           ?         0           
===========================================
  Hits               ?         5           
  Misses             ?         0           
  Partials           ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ooooo-create
Copy link
Contributor Author

/re-run all-failed

1 similar comment
@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 8, 2025

Sorry to inform you that 460ea65's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 21, 2025

Sorry to inform you that 0094b98's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@luotao1 luotao1 closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneaxiy sneaxiy Awaiting requested review from sneaxiy

@raindrops2sea raindrops2sea Awaiting requested review from raindrops2sea

@ForFishes ForFishes Awaiting requested review from ForFishes

Assignees

@luotao1 luotao1

@lshpku lshpku

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ooooo-create @codecov-commenter @luotao1 @lshpku