[CodeStyle][Ruff] Introduce rule B005 and fix discovered bugs
#72896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
May 22, 2025
| @@ -97,9 +97,11 @@ def prune_fp16(block, shard, reduced_grads_to_param, ring_ids): | |||
| output_name = op.desc.output_arg_names()[0] | |||
| # TODO (JZ-LIANG) revise this for uniform mixed parallelism | |||
| param_name = ( | |||
| output_name.strip("@GRAD@MERGED") | |||
| output_name.removeprefix("@GRAD@MERGED").removesuffix( | |||
There was a problem hiding this comment.
这里 removesuffix 就好，因为老 IR 里这些一定是后缀，或者说这里可以改成
param_name = output_name.removesuffix("@MERGED").removesuffix("@GRAD")这样就好了，也不用加什么 if
B005 ruleB005 and fix discovered bugs
|
skip-reason: codestyle only |
SigureMo
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Not User Facing
Description
B005规则，用于明确删除前缀后缀字符串缀意图Link:
.strip()with multi-character strings is misleading the reader #52103