-
Notifications
You must be signed in to change notification settings - Fork 5.8k
为paddle.less_than、paddle.less_equal、paddle.greater_than、paddle.greater_equal添加复数类型支持 #72619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
class TestLessEqualComplex128Api(op_test.OpTest): | ||
def setUp(self): | ||
self.op_type = 'less_equal' | ||
self.typename = ("float64", "complex128") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的typename[1]是不是可以删掉
T ar = a.real; \ | ||
T br = b.real; \ | ||
T ai = a.imag; \ | ||
T bi = b.imag; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的中间变量感觉可以省掉?直接用a.real op b.real
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个地方我在之后的PR更改吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…r_equal添加复数类型支持 (PaddlePaddle#72619) * update code * update api * fix less_than
PR Category
User Experience
PR Types
Others
Description
为paddle.less_than、paddle.less_equal、paddle.greater_than、paddle.greater_equal添加复数类型支持