Skip to content

frobenius_norm support complex input #72577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 9, 2025
Merged

frobenius_norm support complex input #72577

merged 14 commits into from
Jun 9, 2025

Conversation

aquagull
Copy link
Contributor

@aquagull aquagull commented May 5, 2025 •
edited
Loading

PR Category

User Experience

PR Types

Others

Description

  1. 修复无法正确处理负数axis的问题
axis=[-2, -1]
shape_x=[0, 1, 2, 1]
out = paddle.linalg.matrix(x=paddle.zeros(shape=shape_x), p=np.inf, axis = axis)

image
2. forbenius_norm支持complex 输入

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 5, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label May 5, 2025
@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented May 18, 2025

Sorry to inform you that 22a30c7's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@aquagull aquagull mentioned this pull request May 18, 2025
Open
12 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@41aa80a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
python/paddle/tensor/linalg.py 75.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (81.81%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #72577   +/-   ##
==========================================
  Coverage           ?   81.81%           
==========================================
  Files              ?        3           
  Lines              ?       11           
  Branches           ?        0           
==========================================
  Hits               ?        9           
  Misses             ?        2           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aquagull aquagull changed the title fix paddle.matrix_norm paddle.matrix_norm support complex input Jun 4, 2025
@aquagull aquagull changed the title paddle.matrix_norm support complex input frobenius_norm support complex input Jun 6, 2025
HydrogenSulfate
HydrogenSulfate approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit fa0f36f into PaddlePaddle:develop Jun 9, 2025
49 of 50 checks passed
shanjiang7 pushed a commit to shanjiang7/Paddle that referenced this pull request Jun 12, 2025
@aquagull @shanjiang7
frobenius_norm support complex input (PaddlePaddle#72577)
1556757 
* fix p

* fix _backshift_permutation

* update

* update

* fix

* revert kernel change, code-style

* fix

* fix

* fix

* fix

* fix

* add test
@aquagull aquagull deleted the matrix_norm branch August 8, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HydrogenSulfate HydrogenSulfate HydrogenSulfate approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aquagull @codecov-commenter @HydrogenSulfate