-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Paddle Tensor 规范化第二期】paddle.svd support complex and 0-size #72169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
对于svd反向传播,使用了torch(2.6.0)进行对比测试,对齐了torch的实现
|
Sorry to inform you that 5a523ce's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
paddle/phi/kernels/cpu/svd_kernel.cc
Outdated
U->Resize(U->dims()); | ||
S->Resize(S->dims()); | ||
VH->Resize(VH->dims()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U, S, VH的size应该在infermeta里设置好了,这里可能不用再resize了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
@fangfangssj 覆盖率好象没过 |
这部分是关于复数的,没有写对应的单测,但是对齐了torch |
okok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for skipif
@fangfangssj 加一个调用反向的单测,仅作功能测试,以此满足代码覆盖率需求 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #72169 +/- ##
==========================================
Coverage ? 99.25%
==========================================
Files ? 4
Lines ? 134
Branches ? 0
==========================================
Hits ? 133
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ddle#72169) * support complex * fix * fix * fix * fix * fix ci * rerun ci * fix * add test * fix ci --------- Co-authored-by: fangfangssj <fangfangssj@qq.com>
PR Category
User Experience
PR Types
Bug fixes
Description
Pcard-75624
前置PR,为Pow算子支持复数
实数的SVD反向传播参考https://j-towns.github.io/papers/svd-derivative.pdf
复数的SVD反向传播参考https://arxiv.org/pdf/1909.02659