Skip to content

Conversation

NKNaN
Copy link
Contributor

@NKNaN NKNaN commented Nov 4, 2024

PR Category

User Experience

PR Types

Bug fixes

Description

  1. paddle.distribution.Poisson 修复 0-D 参数输入;
  2. 将 distribution API 的 sample/rsample 方法默认值全部替换为 []

Copy link

paddle-bot bot commented Nov 4, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 4, 2024
@@ -250,7 +250,7 @@ def entropy(self) -> Tensor:
"""
return paddle.log(self.scale) + 1 + np.euler_gamma

def sample(self, shape: Sequence[int]) -> Tensor:
def sample(self, shape: Sequence[int] = ()) -> Tensor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle中更习惯用list形式来表示shape,看能不能全部换成这种写法:[]

@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Nov 12, 2024

@NKNaN 这个按另一个PR的标准,也修改一下吧。另外CI还有问题

Copy link

paddle-ci-bot bot commented Nov 13, 2024

Sorry to inform you that f1ac0c4's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@NKNaN NKNaN force-pushed the zerodim-distribution2 branch from f1ac0c4 to 153096c Compare November 14, 2024 09:35
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 1906d90 into PaddlePaddle:develop Nov 18, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants