【complex op No.10】sqrt #68149
Closed
【complex op No.10】sqrt #68149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
|
|
|
| struct SqrtFunctor<ComplexType<T>> : public BaseActivationFunctor<T> { | ||
| template <typename Device, typename X, typename Out> | ||
| void operator()(Device d, X x, Out out) const { | ||
| out.device(d) = x.sqrt(); |
There was a problem hiding this comment.
这个跟上面的不带complex的运算逻辑一样，是否还需要单独特化一个struct
| @@ -759,6 +767,23 @@ struct SqrtGradFunctor : public BaseActivationFunctor<T> { | |||
| } | |||
| }; | |||
|
|
|||
| template <typename T> | |||
| struct SqrtGradFunctor<ComplexType<T>> : public BaseActivationFunctor<T> { | |||
There was a problem hiding this comment.
改为BaseActivationFunctor<ComplexType>会不会好些
| self.dtype = np.complex64 | ||
|
|
||
| def test_check_output(self): | ||
| pass |
|
Sorry to inform you that 501e467's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
New features
Description
add complex support for sqrt