Skip to content

Conversation

inaomIIsfarell
Copy link
Contributor

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • python/paddle/incubate/operators/softmax_mask_fuse.py
  • python/paddle/incubate/operators/softmax_mask_fuse_upper_triangle.py

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Jul 31, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

标注的没啥问题, CI 检查错误,是因为文件名与函数名重名了 ~

可以在示例代码中添加 ignore,如:

rst = incubate.softmax_mask_fuse_upper_triangle(x) # type: ignore[operator]

这里的两个示例都需要改一下 ~

@luotao1 luotao1 added contributor External developers HappyOpenSource 快乐开源活动issue与PR labels Jul 31, 2024
Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~

@luotao1 luotao1 merged commit 13c34ad into PaddlePaddle:develop Aug 2, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants