Skip to content

【Hackathon 6th Fundable Projects 4 No.5】remove reduce_op_handle/all_reduce_op_handle -part #65894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 17, 2024
Merged

【Hackathon 6th Fundable Projects 4 No.5】remove reduce_op_handle/all_reduce_op_handle -part #65894

merged 11 commits into from
Jul 17, 2024

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Jul 9, 2024 •
edited
Loading

PR Category

Others

PR Types

Deprecations

Description

  1. remove all_reduce_op_handle/reduce_op_handle/broadcast_op_handle/bkcl_op_handle
  2. remove build_strategy.remove_unnecessary_lock

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jul 9, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 9, 2024
@ccsuzzh ccsuzzh requested review from phlrain and qili93 as code owners July 11, 2024 13:22
@ccsuzzh ccsuzzh mentioned this pull request Jul 11, 2024
Closed
13 tasks
@ccsuzzh ccsuzzh changed the title test remove multi_devices_pass 【Hackathon 6th Fundable Projects 4 No.5】remove reduce_op_handle/all_reduce_op_handle -part Jul 14, 2024
wanghuancoder
wanghuancoder approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XieYunshen
XieYunshen approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 827eb1e into PaddlePaddle:develop Jul 17, 2024
lixcli pushed a commit to lixcli/Paddle that referenced this pull request Jul 22, 2024
@ccsuzzh @lixcli
【Hackathon 6th Fundable Projects 4 No.5】remove reduce_op_handle/all_r…
711ed86 
…educe_op_handle -part (PaddlePaddle#65894)

* test remove multi_devices_pass

* remove modify_op_lock_and_record_event_pass

* remove reduce_op_handle

* remove FLAGS_cpu_deterministic

* clean useless code

* clean useless code

* fix ci

* remove blank lines
@ccsuzzh ccsuzzh deleted the reduce_op_handle branch July 22, 2024 12:26
@ccsuzzh ccsuzzh mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@phlrain phlrain phlrain approved these changes

@zhwesky2010 zhwesky2010 Awaiting requested review from zhwesky2010 zhwesky2010 is a code owner

@Aurelius84 Aurelius84 Awaiting requested review from Aurelius84

@qili93 qili93 Awaiting requested review from qili93 qili93 is a code owner

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccsuzzh @wanghuancoder @XieYunshen @phlrain @luotao1