Skip to content

Conversation

megemini
Copy link
Contributor

@megemini megemini commented Jul 9, 2024

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • python/paddle/sparse/nn/layer/norm.py

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Jul 9, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@megemini
Copy link
Contributor Author

megemini commented Jul 9, 2024

Update 20240709

特别说明:

python/paddle/sparse/nn/layer/norm.py 中的 class BatchNorm(paddle.nn.BatchNorm1D): 可能实现逻辑有问题 ~

BatchNorm 的初始化参数为:

  • data_format: Literal["NDHWC", "NHWC"] = "NDHWC",

BatchNorm1D 的参数为:

  • data_format: DataLayout1D = 'NCL',

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit 8b7edfa into PaddlePaddle:develop Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants