Skip to content

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jul 9, 2024

PR Category

User Experience

PR Types

Improvements

Description

Copy link

paddle-bot bot commented Jul 9, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -148,7 +164,7 @@ def __init__(self, df, loc, scale, name=None):
super().__init__(batch_shape)
self._chi2 = Gamma(0.5 * self.df, paddle.full_like(self.df, 0.5))

def _check_nonnegative(self, value):
def _check_nonnegative(self, value: Tensor) -> Tensor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def _check_nonnegative(self, value: Tensor) -> Tensor:
def _check_nonnegative(self, value: Tensor) -> bool:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 10, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 4c6f2ce into PaddlePaddle:develop Jul 10, 2024
@enkilee enkilee deleted the typing-b25 branch January 8, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants