[Typing][B-18] Add type annotations for python/paddle/distribution/laplace.py
#65784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 8, 2024
|
|
||
| def __init__(self, loc, scale): | ||
| def __init__(self, loc: Numberic, scale: Numberic) -> None: |
There was a problem hiding this comment.
用 float | Tensor ？
Numberic: TypeAlias = Union[int, float, complex, np.number, "Tensor"] 中的 complex 貌似不能支持？
In [4]: >>> import paddle
...: >>> paddle.seed(2023)
...: >>> m = paddle.distribution.Laplace(1+1j, 2+1j)
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
Cell In[4], line 3
1 import paddle
2 paddle.seed(2023)
----> 3 m = paddle.distribution.Laplace(1+1j, 2+1j)
File ~/venv38dev/lib/python3.8/site-packages/paddle/distribution/laplace.py:60, in Laplace.__init__(self, loc, scale)
56 def __init__(self, loc, scale):
57 if not isinstance(
58 loc, (numbers.Real, framework.Variable, paddle.pir.Value)
59 ):
---> 60 raise TypeError(
61 f"Expected type of loc is Real|Variable, but got {type(loc)}"
62 )
64 if not isinstance(
65 scale, (numbers.Real, framework.Variable, paddle.pir.Value)
66 ):
67 raise TypeError(
68 f"Expected type of scale is Real|Variable, but got {type(scale)}"
69 )
TypeError: Expected type of loc is Real|Variable, but got <class 'complex'>
Comment on lines
61
to
62
| loc: Numberic | ||
| scale: Numberic |
There was a problem hiding this comment.
Suggested change
| loc: Numberic | |
| scale: Numberic | |
| loc: Tensor | |
| scale: Tensor |
实例化之后，loc scale 的值都转换为了 Tensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
-
python/paddle/distribution/laplace.pyRelated links
@SigureMo @megemini