[Typing] 引入 type hint 单元测试
#65740
Closed
[Typing] 引入 type hint 单元测试
#65740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
This was referenced Jul 5, 2024
|
我记得原定计划是不引入单元测试的？ |
嗯 ～ 之前计划只引入 这里先把层级结构搭建好，如果有需要的话往里面加就行 ～ 主要是，没有测试总不放心 🫠🫠🫠 有啥其他顾虑？ |
|
#63604 说的也是不再额外添加单测，RFC 也是，为什么突然又加了呢？ 加的话按照什么原则加呢？哪些需要加哪些不需要加？ 维护成本又要怎样考虑呢？将来谁来维护呢？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
_typing模块的单元测试_typing.basic.py以用于测试注：
此测试模块，不单是测试
_typing模块，是整个type hint单独的测试用例此处只添加了部分测试用例，可后续完善
后续可以在
test/_typing中添加主测试用例，如test_<module>.pytest/_typing/<module>/pass中添加通过的测试用例test/_typing/<module>/fail中添加失败的用例(用# type: ignore[xxx]可跳过的视为失败用例)test/_typing/<module>reveal中添加推导的用例这里区分 module 的主要原因是，如果都放在一个测试文件中，timeout 可能会很大 ～
关联 PR #63597
p.s. 首次添加测试模块，可能需要先调试一下 ～
@SigureMo