【Hackathon 6th No.9】Add cartesian_prod API to Paddle -part #65605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
reviewed
Jul 2, 2024
python/paddle/tensor/math.py
Outdated
| [2, 5], | ||
| [2, 6], | ||
| [3, 5], | ||
| [3, 6]]) |
There was a problem hiding this comment.
可以多加两个例子
- 只输入 1 个 tensor
- shape 中有 0 的情况；
paddle/phi/kernels/reshape_kernel.cc
Outdated
| } | ||
| // if (x.numel() == 0) { | ||
| // return; | ||
| // } |
There was a problem hiding this comment.
这里是测试case中静态图的时候发现如果输入的 x 中有 zero-size tensor，静态图最终会返回 None，然后排查了一下应该是 reshape op 在静态图下输入是 zero-size tensor 的话会返回 None。（如果输入的 x 中有 zero-size tensor，静态图下 coordinates = paddle.stack(paddle.meshgrid(x), axis=-1) 这一步有返回结果，且coordinates也会是 zero-size tensor，最后一步 reshape 返回了 None）
如果注释掉 kernel 这里的直接 return，静态图就返回的是 []，动态图没有影响，不知道这样改对不对。
|
可以提交中文文档 |
SigureMo
approved these changes
Jul 10, 2024
|
|
||
| Args: | ||
| x (list[Tensor]|tuple[Tensor]): Any number of 1-D input Tensors. Supported data types: bfloat16, float16, float32, float64, int32, int64, complex64 or complex128. | ||
| name (str, optional): Name for the operation (optional, default is None). For more information, please refer to :ref:`api_guide_Name`. |
There was a problem hiding this comment.
Suggested change
| name (str, optional): Name for the operation (optional, default is None). For more information, please refer to :ref:`api_guide_Name`. | |
| name (str|None, optional): Name for the operation (optional, default is None). For more information, please refer to :ref:`api_guide_Name`. |
这个不重要，可以在之后哪个 PR 顺手改一下就可以～
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
Add paddle.cartesian_prod
rfc: PaddlePaddle/community#914