Skip to content

[Typing][A-81] Add type annotations for paddle/vision/models/resnet.py #65487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2024
Merged

[Typing][A-81] Add type annotations for paddle/vision/models/resnet.py #65487

merged 4 commits into from
Jun 27, 2024

Conversation

Asthestarsfalll
Copy link
Contributor

PR Category

User Experience

PR Types

Improvements

Description

Add type annotations for paddle/vision/models/resnet.py

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jun 26, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 26, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 26, 2024
@megemini megemini mentioned this pull request Jun 26, 2024
Closed
SigureMo
SigureMo reviewed Jun 26, 2024
View reviewed changes
python/paddle/vision/models/resnet.py Outdated
groups: int = 1,
base_width: int = 64,
dilation: int = 1,
norm_layer: type[nn.BatchNorm2D] | None = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type[nn.Layer]？这要是固定 nn.BatchNorm2D 就没意义了吧？

还是说意义就是用来区分 None 和 BatchNorm2D？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看代码ResNet里是写死为BatchNorm2D了，使用Layer也可以

python/paddle/vision/models/resnet.py Outdated
inplanes: int,
planes: int,
stride: Size2 = 1,
downsample: nn.Sequential | None = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个可以是其他 Layer 吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

也可以 稍后修改

megemini
megemini reviewed Jun 26, 2024
View reviewed changes
@SigureMo SigureMo mentioned this pull request Jun 26, 2024
Merged
SigureMo
SigureMo previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
Copy link
Member

SigureMo commented Jun 27, 2024 •
edited
Loading

啊不对，Static check 有点问题得看看（刚刚手快直接 rerun 了

megemini
megemini reviewed Jun 27, 2024
View reviewed changes
@SigureMo SigureMo merged commit 10a4dcc into PaddlePaddle:develop Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

+1 more reviewer

@megemini megemini megemini left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Asthestarsfalll @SigureMo @megemini @luotao1