[Typing][A-12] Add type annotations for paddle/tensor/stat.py
#65337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jun 20, 2024
python/paddle/tensor/stat.py
Outdated
| def mean(x, axis=None, keepdim=False, name=None): | ||
| def mean( | ||
| x: Tensor, | ||
| axis: NestedSequence[int] | None = None, |
There was a problem hiding this comment.
这个支持无限级嵌套？不然的话 int | Sequence[int] 是否满足？
python/paddle/tensor/stat.py
Outdated
| x: Tensor, | ||
| axis: NestedSequence[int] | None = None, | ||
| keepdim: bool = False, | ||
| mode: str = 'avg', |
python/paddle/tensor/stat.py
Outdated
| keepdim: bool = False, | ||
| mode: str = 'avg', | ||
| name: str | None = None, | ||
| ) -> Tensor | tuple[Tensor, Tensor]: |
There was a problem hiding this comment.
是否可以通过 overload 直接区分？可参考 #65274 (comment)
… pr/ooooo-create/65337
megemini
reviewed
Jun 20, 2024
python/paddle/tensor/stat.py
Outdated
Comment on lines
697
to
699
| interpolation: Literal[ | ||
| 'linear', 'higher', 'lower', 'midpoint', 'nearest' | ||
| ] = "linear", |
There was a problem hiding this comment.
是不是可以在这个文件加一个非公开的类型:
_Interpolation: TypeAlias = Literal[
'linear', 'higher', 'lower', 'midpoint', 'nearest'
]然后这里的几个接口复用一下？～
SigureMo
reviewed
Jun 20, 2024
| def nanquantile( | ||
| x: Tensor, | ||
| q: float | Sequence[float] | Tensor, | ||
| axis: list[int] | int = None, |
There was a problem hiding this comment.
Suggested change
| axis: list[int] | int = None, | |
| axis: Sequence[int] | int = None, |
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
SigureMo
reviewed
Jun 21, 2024
SigureMo
reviewed
Jun 21, 2024
python/paddle/tensor/stat.py
Outdated
| axis: int | list[int] | None = None, | ||
| keepdim: bool = False, | ||
| interpolation: _Interpolation = "linear", | ||
| name: str | None = None, |
There was a problem hiding this comment.
怎么原来没有 name 的加了 name 呢？不要修改 API，不止这一个有这个问题
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
…lePaddle#65337) --------- Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
…lePaddle#65337) --------- Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
Related links
@SigureMo @megemini