Skip to content

Conversation

86kkd
Copy link
Contributor

@86kkd 86kkd commented Jun 22, 2024

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • python/paddle/vision/models/vgg.py.py

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Jun 22, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -177,7 +198,13 @@ def make_layers(cfg, batch_norm=False):
}


def _vgg(arch, cfg, batch_norm, pretrained, **kwargs):
def _vgg(
arch,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch 的类型?

@paddle-bot paddle-bot bot added the contributor External developers label Jun 22, 2024
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
@86kkd 86kkd requested a review from SigureMo June 22, 2024 23:25
@86kkd 86kkd force-pushed the 86kkd branch 2 times, most recently from e124f98 to f67660e Compare June 23, 2024 02:12
@86kkd
Copy link
Contributor Author

86kkd commented Jun 23, 2024

sorry我不是很熟悉开源的工作流程,我完成了a-86的annotations但是没有新建一个pr,我没找到撤回remote commit的方法所以就force push覆盖掉a-86的commit,

@megemini
Copy link
Contributor

megemini commented Jun 23, 2024

sorry我不是很熟悉开源的工作流程,我完成了a-86的annotations但是没有新建一个pr,我没找到撤回remote commit的方法所以就force push覆盖掉a-86的commit,

可以参考一下 https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/code_contributing_path_cn.html#daimagongxianliucheng

以及《贡献指南》里面的 https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/api_contributing_guides/new_python_api_cn.html#api-python 都可以先看一下 ~ 🤟🤟🤟

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit e78c557 into PaddlePaddle:develop Jun 23, 2024
@86kkd 86kkd deleted the 86kkd branch June 23, 2024 18:14
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 24, 2024
@luotao1
Copy link
Contributor

luotao1 commented Jun 24, 2024

hi, @86kkd

  • 非常感谢你对飞桨的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 ext_paddle_oss@baidu.com,我们会邀请你加入~

co63oc pushed a commit to co63oc/Paddle that referenced this pull request Jun 25, 2024
…vgg.py` (PaddlePaddle#65381)


---------

Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Jun 25, 2024
…vgg.py` (PaddlePaddle#65381)


---------

Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
@luotao1
Copy link
Contributor

luotao1 commented Oct 15, 2024

亲爱的开发者: @86kkd

恭喜你完成「快乐开源任务/热身打卡任务」,你将获得一份精美礼品。请在10月18日前,通过填写以下问卷,留下你的邮寄地址。

期待未来,你我并肩在开源的世界走得更远!

请点击:https://paddle.wjx.cn/vm/h4On9gJ.aspx#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants