[Typing][A-66,A-67] Add type annotations for tensor patched methods #65201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
commented
Jun 15, 2024
| @@ -758,50 +797,13 @@ def get_device_dtype_from_tensor(other): | |||
| ) | |||
| return self._to(device, dtype, blocking) | |||
|
|
|||
| @property | |||
| def grad(self): | |||
There was a problem hiding this comment.
无用方法，EagerTensor 已经直接在 C++ 端定义
这里应该是给老动态图的 VarBase patch 的，老动态图 VarBase 很久之前就退场了
zrr1999
previously approved these changes
Jun 16, 2024
Comment on lines
991
to
998
| item: ( | ||
| None | ||
| | bool | ||
| | int | ||
| | slice | ||
| | tuple[None | bool | int | slice, ...] | ||
| | list[Tensor | bool | int] | ||
| ), |
zrr1999
approved these changes
Jun 16, 2024
Comment on lines
1006
to
1011
| None | ||
| | bool | ||
| | int | ||
| | slice | ||
| | tuple[None | bool | int | slice, ...] | ||
| | list[Tensor | bool | int] |
megemini
reviewed
Jun 17, 2024
| def __getitem__( | ||
| self, | ||
| item: TensorIndex, | ||
| ): |
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
为 Tensor patch 的方法添加类型提示
Related links
PCard-66972