[Typing] Tensor stub property setter and stub add comment twice #65119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jun 13, 2024
| @@ -19,7 +19,7 @@ | |||
| # Import common typings for generated methods | |||
| # isort: off | |||
| from typing import * # noqa: F403 | |||
| from typing_extensions import * # noqa: F403 | |||
| from typing_extensions import * # type: ignore # noqa: F403 | |||
There was a problem hiding this comment.
mypy 检查这个文件的时候提示：
像是兼容问题导致的 ～
我觉得吧，目前可以暂时先这样，最后还是要去掉 import * ，然后加上对于 tensor.pyi 的 mypy 检查 ～
There was a problem hiding this comment.
后面 __radd__ 的那几个
没什么影响，所以加上了 ～
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
Bug fixes
Description
修改:
@SigureMo