[Typing][A-1] Add type annotations for paddle/tensor/array.py
#65009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jun 11, 2024
python/paddle/tensor/array.py
Outdated
| @@ -57,16 +72,16 @@ def array_length(array): | |||
| elif in_pir_mode(): | |||
| if ( | |||
| not isinstance(array, paddle.pir.Value) | |||
| or not array.is_dense_tensor_array_type() | |||
| or not array.is_dense_tensor_array_type() # type: ignore | |||
There was a problem hiding this comment.
我们代码里就不要加 # type: ignore 了吧，不然太多了，只在示例代码，以及我们自己写的代码里加吧，别人写的代码不用管
@megemini 觉得呢
There was a problem hiding this comment.
我们代码里就不要加
# type: ignore了吧，不然太多了，只在示例代码，以及我们自己写的代码里加吧，别人写的代码不用管
嗯 ～ 加这个东西是为了过测试 ～ Paddle 本身不需要 mypy 检查，暂时也就没必要加这个了 ～
目前在 Example 里面的代码加上（如有必要）就行 ～
megemini
reviewed
Jun 11, 2024
python/paddle/tensor/array.py
Outdated
Comment on lines
111
to
113
| def array_read( | ||
| array: list[T] | paddle.Tensor, i: paddle.Tensor | ||
| ) -> T | paddle.Tensor: |
There was a problem hiding this comment.
这个地方是否还需要添加类型？
python 官方的例子是没有的：
@overload
def utf8(value: None) -> None:
pass
@overload
def utf8(value: bytes) -> bytes:
pass
@overload
def utf8(value: unicode) -> bytes:
pass
def utf8(value):
<actual implementation>感觉多少有点冗余 ～
There was a problem hiding this comment.
paddle/tensor/array.py
megemini
reviewed
Jun 12, 2024
There was a problem hiding this comment.
改一下 docstring 中的返回值写法吧：
Returns:
Tensor: 0-D Tensor with shape [], which is the length of array.改为
Returns:
Tensor, 0-D Tensor with shape [], which is the length of array.参考讨论：#65064 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：