Skip to content

[Typing] Add type annotations for base decorators #64954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 13, 2024
Merged

[Typing] Add type annotations for base decorators #64954

merged 11 commits into from
Jun 13, 2024

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Jun 6, 2024 •
edited
Loading

PR Category

User Experience

PR Types

Improvements

Description

为基础装饰器添加类型提示，以便支持类型推导，比如

@static_only
def data(name: str, shape: ShapeLike, dtype: DTypeLike | None = None, lod_level: int = 0) -> paddle.Tensor:

这里 static.data 原函数虽然标注了，但是公开的 API 是装饰后的，经过装饰后类型就没了，本 PR 修改了相关基础装饰器，确保公开 API 的类型签名是不变的

@megemini

Tip

仅类型提示 PR，不影响运行时

PCard-66972

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jun 6, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

SigureMo
SigureMo commented Jun 6, 2024
View reviewed changes
python/paddle/pir/__init__.pyi Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件好像也得加到 setup.py 才能打包

@megemini megemini mentioned this pull request Jun 10, 2024
Closed
@SigureMo SigureMo requested a review from zrr1999 June 12, 2024 08:33
@SigureMo SigureMo mentioned this pull request Jun 12, 2024
Merged
@SigureMo SigureMo changed the title [Typing] Add type annotations for base decorators Add type annotations for base decorators Jun 12, 2024
wanghuancoder
wanghuancoder approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aurelius84
Aurelius84 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@SigureMo SigureMo changed the title Add type annotations for base decorators [Typing] Add type annotations for base decorators Jun 13, 2024
@SigureMo SigureMo merged commit 3768840 into PaddlePaddle:develop Jun 13, 2024
@SigureMo SigureMo deleted the typing/decorators branch June 13, 2024 04:43
@SigureMo SigureMo mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@zrr1999 zrr1999 zrr1999 approved these changes

@XiaoguangHu01 XiaoguangHu01 Awaiting requested review from XiaoguangHu01 XiaoguangHu01 is a code owner

@zhiqiu zhiqiu Awaiting requested review from zhiqiu zhiqiu is a code owner

@Xreki Xreki Awaiting requested review from Xreki Xreki is a code owner

@qili93 qili93 Awaiting requested review from qili93 qili93 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SigureMo @Aurelius84 @wanghuancoder @zrr1999