-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Hackathon 6th No.55】move fake_quantize_dequantize_moving_average_abs_max/fake_quantize_dequantize_abs_max op to phi #63737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
感觉应该是梯度计算出问题了,我试过将fluid中的方法改写成phi的格式,并将functor迁移到phi下,是可以通过CI中报错的单测的,但是将整个op迁移到phi下就产生了错误,需要老师帮忙看一下怎么解决。 |
self.check_grad( | ||
['X'], 'Out', user_defined_grads=gradient, check_dygraph=False | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci上看到这个单测通过了,你重新提交一个commit过下所有CI再观察下
_C_ops.assign_out_(out2, self._scale) | ||
_C_ops.assign_out_(out3, state) | ||
_C_ops.assign_out_(out4, accum) | ||
return quant_out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YuanRisheng 麻烦老师帮忙看下_(:з」∠)_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
试试用_is_initialized方法先判断一下out,再选择看是否assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
试试用_is_initialized方法先判断一下out,再选择看是否assign
判断out2,不是判断_scale
CI通过了~ |
…_max/fake_quantize_dequantize_moving_average_abs_max op to phi - part (PaddlePaddle#63737) * move functor to phi * fix namespace * modify to phi method and fix the bug in dequantize_log op when set the pir * move fake_quantize_dequantize_moving_average_abs_max to phi * fix bug * move fake_quantize_dequantize_abs_max to phi * roback * modify the dynamic graph function call * fix dynamic modify * still have bug * add the assign * roback * merge * merge * fix bug * fix merge bug * fix bug * fix bug * fix bug
PR Category
Others
PR Types
Others
Description
需先Merge前置PR:#63732
move fake_quantize_dequantize_moving_average_abs_max to phi