【Hackathon 6th No.3】为 Paddle 新增 ZeroPad1D / ZeroPad3D / block_diag API -part #63728

ADream-ki · 2024-04-22T02:37:47Z

PR Category

Others

PR Types

Others

Description

为paddle补齐zeropad1d和zeropad3d api，同时添加block_diag api以丰富paddle功能

paddle-bot · 2024-04-22T02:37:52Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

ADream-ki · 2024-05-07T06:15:37Z

已经好了 @luotao1 @Charles-hit

paddle-ci-bot · 2024-05-08T03:28:14Z

Sorry to inform you that 2cb256d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Charles-hit

Pad 可以cpu gpu都测试一下

…ask2

ADream-ki · 2024-05-10T04:38:20Z

Pad 可以cpu gpu都测试一下

已经好了

Charles-hit

PR描述加一下吧

ADream-ki · 2024-05-14T03:29:41Z

PR描述加一下吧

已经好了，请review

jeff41404 · 2024-05-16T04:16:01Z

python/paddle/nn/layer/padding.py

+from .layers import Layer
+
+
+class ZeroPad1D(Layer):


why not add ZeroPad1D and ZeroPad3D in python/paddle/nn/layer/common.py, together with ZeroPad2D for easy maintenance in the future?

Because according to the requirements in the task, I need to implement it in the corresponding file instead of ‘common.py’ @jeff41404

抱歉这边的话还是放一起合适点。 @Chen-Lun-Hao

好的，那我移到common那里去

paddle-ci-bot · 2024-05-17T03:25:04Z

Sorry to inform you that b382c5e's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

ADream-ki · 2024-05-20T05:08:32Z

I have already run CI again @jeff41404

ADream-ki · 2024-05-20T07:57:28Z

已经修改，同时已更新rfc @Charles-hit @jeff41404

ADream-ki · 2024-05-21T22:52:46Z

pr已经全部实现，能不能先不关闭？ @luotao1

jeff41404 · 2024-05-22T04:35:03Z

python/paddle/tensor/manipulation.py

@@ -6861,3 +6861,67 @@ def slice_scatter(x, value, axes, starts, ends, strides, name=None):
        )

        return output
+
+
+def block_diag(*inputs, name=None):


According to the current specification of PaddlePaddle, when the input may be multiple tensors, the parameters cannot be passed in this way. You need to put multiple tensors into a list or tuple before passing in. Please refer to the broadcast_tensors API

…ask2

ADream-ki · 2024-05-22T04:46:48Z

PaddlePaddle/community#906 對應的rfc也修改了

ADream-ki · 2024-05-27T10:12:45Z

I have made the changes, please review @jeff41404

jeff41404

LGTM

paddle-ci-bot · 2024-05-31T03:14:06Z

Sorry to inform you that d05dd19's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

sunzhongkai588

LGTM for docs

luotao1

和 @jeff41404 @zhwesky2010 讨论：
def zeropad2d( 可以废弃。辛苦在

Paddle/python/paddle/nn/functional/common.py

Lines 1883 to 1887 in fc1d21a

    
           def zeropad2d( 
        
               x: Tensor, 
        
               padding: ShapeLike, 
        
               data_format: DataLayout2D = "NCHW", 
        
               name: str | None = None,

前面加一个 @deprecated(，类似

Paddle/python/paddle/dataset/imdb.py

Lines 78 to 83 in fc1d21a

    
           @deprecated( 
        
               since="2.0.0", 
        
               update_to="paddle.text.datasets.Imdb", 
        
               level=1, 
        
               reason="Please use new dataset API which supports paddle.io.DataLoader", 
        
           )

     since="3.0.0", 
     update_to="paddle.nn.ZeroPad2D",

@Chen-Lun-Hao

ADream-ki · 2024-06-25T01:45:01Z

和 @jeff41404 @zhwesky2010 讨论： def zeropad2d( 可以废弃。辛苦在

Paddle/python/paddle/nn/functional/common.py

Lines 1883 to 1887 in fc1d21a

def zeropad2d(

x: Tensor,

padding: ShapeLike,

data_format: DataLayout2D = "NCHW",

name: str | None = None,

前面加一个 @deprecated(，类似

Paddle/python/paddle/dataset/imdb.py

Lines 78 to 83 in fc1d21a

@deprecated(

since="2.0.0",

update_to="paddle.text.datasets.Imdb",

level=1,

reason="Please use new dataset API which supports paddle.io.DataLoader",

)
     since="3.0.0", 
     update_to="paddle.nn.ZeroPad2D", 
@Chen-Lun-Hao

好的

ADream-ki added 2 commits April 21, 2024 23:36

add api

03a43c3

update zeropad1 test

05e6050

paddle-bot bot added the contributor External developers label Apr 22, 2024

test

ab0762c

luotao1 added the PaddlePaddle Hackathon label Apr 22, 2024

luotao1 assigned luotao1 and Charles-hit Apr 22, 2024

luotao1 mentioned this pull request Apr 22, 2024

【Hackathon 6th】开源贡献个人挑战赛 #62905

Closed

ADream-ki added 6 commits April 22, 2024 15:05

update block_diag example

5088dbe

update test

7854d91

test

cbf4594

update

edae11d

add block_diag

319e0c5

update

e7a7625

luotao1 added the API label Apr 24, 2024

ADream-ki and others added 6 commits April 25, 2024 14:57

Merge branch 'PaddlePaddle:develop' into task2

db8fce8

Merge branch 'PaddlePaddle:develop' into task2

3f3cc8b

Zeropad

28e80b7

finish

d9fccd4

update test

7bd3ffe

Merge branch 'PaddlePaddle:develop' into task2

2cb256d

Charles-hit reviewed May 9, 2024

View reviewed changes

ADream-ki added 3 commits May 9, 2024 16:13

update cpu/gpu

cda4dca

Merge branch 'task2' of https://github.com/Chen-Lun-Hao/Paddle into t…

d8e24e3

…ask2

update

b382c5e

Charles-hit previously approved these changes May 13, 2024

View reviewed changes

jeff41404 reviewed May 16, 2024

View reviewed changes

update file

9dddaa5

ADream-ki dismissed Charles-hit’s stale review via 9dddaa5 May 20, 2024 07:55

ADream-ki and others added 3 commits May 20, 2024 16:45

update

940d365

update

832059f

Merge branch 'PaddlePaddle:develop' into task2

569ded4

jeff41404 reviewed May 22, 2024

View reviewed changes

ADream-ki added 2 commits May 22, 2024 12:41

update

333f225

Merge branch 'task2' of https://github.com/Chen-Lun-Hao/Paddle into t…

0375e5f

…ask2

ADream-ki added 4 commits May 22, 2024 19:54

update

8fd3aeb

update

97bfa5f

finish

c8b7a84

update

d05dd19

jeff41404 approved these changes May 28, 2024

View reviewed changes

sunzhongkai588 approved these changes Jun 3, 2024

View reviewed changes

luotao1 changed the title ~~【Hackathon 6th No.3】为 Paddle 新增 ZeroPad1D / ZeroPad3D / block_diag API~~ 【Hackathon 6th No.3】为 Paddle 新增 ZeroPad1D / ZeroPad3D / block_diag API -part Jun 3, 2024

luotao1 merged commit 7a8eda5 into PaddlePaddle:develop Jun 3, 2024

sunzhongkai588 mentioned this pull request Jun 3, 2024

【Hackathon 6th No.3】为 Paddle 新增 ZeroPad1D / ZeroPad3D / block_diag API PaddlePaddle/docs#6651

Merged

luotao1 reviewed Jun 24, 2024

View reviewed changes

	def zeropad2d(
	x: Tensor,
	padding: ShapeLike,
	data_format: DataLayout2D = "NCHW",
	name: str \| None = None,

	@deprecated(
	since="2.0.0",
	update_to="paddle.text.datasets.Imdb",
	level=1,
	reason="Please use new dataset API which supports paddle.io.DataLoader",
	)

【Hackathon 6th No.3】为 Paddle 新增 ZeroPad1D / ZeroPad3D / block_diag API -part #63728

【Hackathon 6th No.3】为 Paddle 新增 ZeroPad1D / ZeroPad3D / block_diag API -part #63728

Uh oh!

Conversation

ADream-ki commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Apr 22, 2024

Uh oh!

ADream-ki commented May 7, 2024

Uh oh!

paddle-ci-bot bot commented May 8, 2024

Uh oh!

Charles-hit left a comment

Choose a reason for hiding this comment

Uh oh!

ADream-ki commented May 10, 2024

Uh oh!

Charles-hit left a comment

Choose a reason for hiding this comment

Uh oh!

ADream-ki commented May 14, 2024

Uh oh!

jeff41404 May 16, 2024

Choose a reason for hiding this comment

Uh oh!

ADream-ki May 16, 2024

Choose a reason for hiding this comment

Uh oh!

ADream-ki May 16, 2024

Choose a reason for hiding this comment

Uh oh!

Charles-hit May 20, 2024

Choose a reason for hiding this comment

Uh oh!

ADream-ki May 20, 2024

Choose a reason for hiding this comment

Uh oh!

paddle-ci-bot bot commented May 17, 2024

Uh oh!

ADream-ki commented May 20, 2024

Uh oh!

ADream-ki commented May 20, 2024

Uh oh!

ADream-ki commented May 21, 2024

Uh oh!

jeff41404 May 22, 2024

Choose a reason for hiding this comment

Uh oh!

ADream-ki commented May 22, 2024

Uh oh!

ADream-ki commented May 27, 2024

Uh oh!

jeff41404 left a comment

Choose a reason for hiding this comment

Uh oh!

paddle-ci-bot bot commented May 31, 2024

Uh oh!

sunzhongkai588 left a comment

Choose a reason for hiding this comment

Uh oh!

luotao1 left a comment

Choose a reason for hiding this comment

Uh oh!

ADream-ki commented Jun 25, 2024

Uh oh!

Uh oh!

ADream-ki commented Apr 22, 2024 •

edited

Loading