Skip to content

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Apr 22, 2024

PR Category

Others

PR Types

Others

Description

No.2 完成ParallelExecutor编译模块迁移

Copy link

paddle-bot bot commented Apr 22, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ccsuzzh ccsuzzh changed the title 【Hackathon 6th Fundable Projects 4 No.2】[WIP] test rm _compile_data_parallel -part 【Hackathon 6th Fundable Projects 4 No.2】[WIP] rm parallel executor in pybind -part Apr 25, 2024
@ccsuzzh ccsuzzh changed the title 【Hackathon 6th Fundable Projects 4 No.2】[WIP] rm parallel executor in pybind -part 【Hackathon 6th Fundable Projects 4 No.2】rm parallel executor in pybind -part Apr 28, 2024
Copy link

paddle-ci-bot bot commented May 6, 2024

Sorry to inform you that 0264f47's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

wanghuancoder
wanghuancoder previously approved these changes May 9, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
paddle/fluid/pybind/parallel_executor.cc后面别忘了删除~

@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented May 9, 2024

LGTM paddle/fluid/pybind/parallel_executor.cc后面别忘了删除~

好的,下一个PR开始清理parallel_executor~

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccsuzzh 看下Coverage流水线失败的单测

@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented May 10, 2024

@ccsuzzh 看下Coverage流水线失败的单测

好的,我晚上修复一下~

@ccsuzzh ccsuzzh requested review from wanghuancoder and luotao1 May 20, 2024 00:06
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 47d25a4 into PaddlePaddle:develop May 20, 2024
@ccsuzzh ccsuzzh deleted the mv_pe_compile branch May 20, 2024 08:54
@tianshuo78520a
Copy link
Collaborator

tianshuo78520a commented May 20, 2024

image

好像是冲突了,提了PR进行修复,#64461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants