Skip to content

Conversation

zeroRains
Copy link
Contributor

@zeroRains zeroRains commented Apr 17, 2024

PR Category

Others

PR Types

Others

Description

move dequantize_log to phi

Copy link

paddle-bot bot commented Apr 17, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 17, 2024
@@ -323,6 +323,15 @@
data_type : x
backward : depthwise_conv2d_transpose_grad

- op : dequantize_log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要注册到ops.yaml里,并且把fluid下.cc给删去

Copy link
Contributor Author

@zeroRains zeroRains Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以看一下我的6fe4398 这个commit,之前是删除.cc文件的修改方式,但是在跑单测的时候,好像是没有找到dequantize_log对应的op,所以根据#59359 这个的改法进行修改后单测就没问题了。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle/fluid/pir/dialect/operator/ir/ops.yaml 那这里也配置下吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我配置一下,这是不保留.cc文件时产生的错误
image

@@ -0,0 +1,25 @@
// Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件不是必须的吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在保留.cc文件的修改方法下,如果不配置这个会在编译时发生错误

@luotao1 luotao1 merged commit aba200b into PaddlePaddle:develop Apr 22, 2024
@zeroRains zeroRains deleted the 55_3 branch April 22, 2024 06:36
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 22, 2024
…63638)

* move dequantize_log to phi

* fix typo

* save the dequantize_log_op.cc

* add the config in pir ops.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants