Skip to content

Conversation

DanGuge
Copy link
Contributor

@DanGuge DanGuge commented Apr 1, 2024

PR Category

Distributed Strategy

PR Types

Improvements

Description

  1. 在构建 PipelineLayer 时,对用户传入的 loss_fn 进行判断
  • 如果 loss_fn 不是 list,则将 loss_fn 用 [] 包裹
  • 如果 loss_fn 是 list,则直接设置
  1. 在计算 loss 时,将计算和通信逻辑都调整为 list loss_fn 的逻辑
  2. 在返回 loss 时,根据 len(losses) 的长度,判断用户需要返回 1 个 loss 结果或者多个 loss 结果

Copy link

paddle-bot bot commented Apr 1, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 1, 2024
Copy link

paddle-bot bot commented Apr 1, 2024

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@DanGuge
Copy link
Contributor Author

DanGuge commented Apr 3, 2024

@MarioLulab 辛苦review一下~

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work~ 但还有一些问题,辛苦看下

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还需要增加一些单测~

@DanGuge DanGuge requested a review from MarioLulab April 9, 2024 01:33
@DanGuge
Copy link
Contributor Author

DanGuge commented Apr 9, 2024

@MarioLulab 辛苦review一下~

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work ~
我提了一些小修改,辛苦看下

@DanGuge DanGuge requested a review from MarioLulab April 11, 2024 05:58
@DanGuge
Copy link
Contributor Author

DanGuge commented Apr 11, 2024

nice work ~ 我提了一些小修改,辛苦看下

@MarioLulab 修改好了,辛苦review~

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanGuge
Copy link
Contributor Author

DanGuge commented Apr 11, 2024

@luotao1 辛苦review一下~

@luotao1
Copy link
Contributor

luotao1 commented Apr 12, 2024

辛苦 @ForFishes @GuoxiaWang 审核下

@DanGuge
Copy link
Contributor Author

DanGuge commented Apr 15, 2024

@GuoxiaWang @ForFishes 辛苦review一下~

@DanGuge
Copy link
Contributor Author

DanGuge commented Apr 16, 2024

@luotao1 辛苦review一下~

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 78b038d into PaddlePaddle:develop Apr 16, 2024
Asthestarsfalll pushed a commit to Asthestarsfalll/Paddle that referenced this pull request Apr 17, 2024
* support multiply loss functions in pipeline parallel

* add multiply loss functions test

* add loss_fn_idx for user

* fix bug in output_tensor

* update tests

* update loss fn logger

* fix

* fix

* update tests

* fix is_fp32 & add assert

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants