Skip to content

Fix Paddle-TRT UT fails #61377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2024
Merged

Fix Paddle-TRT UT fails #61377

merged 1 commit into from
Feb 3, 2024

Conversation

leo0519
Copy link
Collaborator

@leo0519 leo0519 commented Jan 31, 2024

PR types

Others

PR changes

Others

Description

Modifications

  • No data type conversion for input of non-floating precision at default if self.input_type is set
  • Align the constraint in UTs with Paddle-TRT op teller

Fix the following UTs:

  • test_trt_convert_bitwise_or
  • test_trt_convert_bitwise_and
  • test_trt_convert_assign
  • test_trt_convert_scatter
  • test_trt_convert_cast

@leo0519 leo0519 added the NVIDIA label Jan 31, 2024
@leo0519 leo0519 requested review from ming1753 and Wangzheee January 31, 2024 01:50
ming1753
ming1753 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ming1753 ming1753 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeng1220 jeng1220 mentioned this pull request Feb 1, 2024
Closed
Wangzheee
Wangzheee approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@Wangzheee Wangzheee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wangzheee Wangzheee merged commit 1291468 into PaddlePaddle:develop Feb 3, 2024
@leo0519 leo0519 mentioned this pull request Feb 5, 2024
Merged
@leo0519 leo0519 deleted the fix-trt-ut branch July 7, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ming1753 ming1753 ming1753 approved these changes

@tianshuo78520a tianshuo78520a Awaiting requested review from tianshuo78520a

+1 more reviewer

@Wangzheee Wangzheee Wangzheee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@heavengate heavengate

Labels
NVIDIA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leo0519 @Wangzheee @ming1753 @heavengate