Skip to content

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Dec 5, 2023

PR types

Others

PR changes

Others

Description

link #58237
需要在 #59445 之后合入
@sunzhongkai588

  • 同时对中文文档进行匹配

Copy link

paddle-bot bot commented Dec 5, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先英文改吧,英文改完中文再同步改

@sunzhongkai588
Copy link
Contributor

sunzhongkai588 commented Dec 7, 2023

好像 diag 也重复了,要不也同理改下?(虽然我觉得 static.variable 这个文档应该没人看)
image

另外,我们要不要像 api_label 一样订一个规范,对于 :name: 后面的写法做个限制?比如diag的示例代码,得写成 :name: diag-example-1 :name: diag-example-2等等 @ooooo-create @SigureMo

@ooooo-create
Copy link
Contributor Author

好像 diag 也重复了,要不也同理改下?(虽然我觉得 static.variable 这个文档应该没人看) image

另外,我们要不要像 api_label 一样订一个规范,对于 :name: 后面的写法做个限制?比如diag的示例代码,得写成 :name: diag-example-1 :name: diag-example-2等等 @ooooo-create @SigureMo

我觉得可以😁😁😁,感觉也不一定,有些是动态图与静态图的区别,不用1 , 2 比较好,尽量包含语义信息 link,要么以api名字开头就行?改的话,中文copy-from也得改,感觉好多😂,不晓得~

@sunzhongkai588
Copy link
Contributor

好像 diag 也重复了,要不也同理改下?(虽然我觉得 static.variable 这个文档应该没人看) image
另外,我们要不要像 api_label 一样订一个规范,对于 :name: 后面的写法做个限制?比如diag的示例代码,得写成 :name: diag-example-1 :name: diag-example-2等等 @ooooo-create @SigureMo

我觉得可以😁😁😁,感觉也不一定,有些是动态图与静态图的区别,不用1 , 2 比较好,尽量包含语义信息 link,要么以api名字开头就行?改的话,中文copy-from也得改,感觉好多😂,不晓得~

@SigureMo 一师傅看看呢?要不要对:name: 写法做限制。 虽然这样做不太优雅好像

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~总算是清理完啦

@luotao1 luotao1 merged commit 2cf724d into PaddlePaddle:develop Dec 12, 2023
@ooooo-create ooooo-create deleted the system_message_10_13 branch March 8, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants