[PIR]Support set_dynamic_shape and refine DoValueCheck #59722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
added 5 commits
December 5, 2023 13:19
0x45f
commented
Dec 6, 2023
| x = paddle.static.data('x', [2, 2], dtype='int8') | ||
| out = paddle.pow(x, 2) | ||
|
|
||
| self.assertRaises(ValueError, x_dtype_error) |
There was a problem hiding this comment.
C++端新增error类型后这里的error会修改为TypeError
YuanRisheng
reviewed
Dec 7, 2023
Aurelius84
reviewed
Dec 11, 2023
YuanRisheng
reviewed
Dec 11, 2023
paddle/fluid/pybind/pir.cc
Outdated
| @@ -848,6 +848,33 @@ void BindType(py::module *m) { | |||
| print_stream << self; | |||
| return print_stream.str(); | |||
| }); | |||
|
|
|||
| m->def("set_shape", [](Type &type, const std::vector<int> &shape) -> Type { | |||
There was a problem hiding this comment.
这个叫create_shaped_type怎么样，感觉set_shape含义不够准确
There was a problem hiding this comment.
如果是动转静专用 api，感觉叫 update_shape_with 或者 replace_shape_with 是不是更准确一些？
There was a problem hiding this comment.
这里函数名改为了create_shaped_type，感觉这个名字准确一点
YuanRisheng
approved these changes
Dec 12, 2023
Aurelius84
approved these changes
Dec 12, 2023
zhangbo9674
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
[PIR]Support set_dynamic_shape and refine DoValueCheck
Pcard-67164