[PIR][Dy2St] Convert Tensor to Value in PIR bind API #59761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Dec 14, 2023
| pir::Value CastPyArg2Value(PyObject* obj, | ||
| const std::string& op_type, | ||
| size_t arg_pos) { | ||
| obj = CastPyArg2ValuePreHook(obj); |
There was a problem hiding this comment.
这里obj可能会返回nullptr，此时会走到函数里的else分支，在报错文案里直接使用->会段错误吧，这里有潜在风险
paddle/fluid/pybind/eager_utils.cc
Outdated
| PyObject* result = PyObject_CallFunction(hook, "O", obj); | ||
| if (result == nullptr) { | ||
| Py_DECREF(obj); | ||
| return nullptr; |
There was a problem hiding this comment.
或者这里是不是不应该允许返回nullptr，应该ENFORCE下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
PIR API 与老 IR 相比并没有统一的
append_op入口，因此可能有 EagerTensor 传入到_C_ops的情况，因此我们会在 C API 处将 Tensor 转为 Value具体实现如下：
添加
set_static_op_arg_pre_cast_hook接口，用于设置一个 hook，在将 PyObject cast 为 Value 之前调用，该 hook 将会在输入是一个 EagerTensor 的时候转换为 Value（利用 ParameterRecorder）在进入动转静时，会同时设置该 hook，在离开动转静时会恢复（时机同
_to_static_mode_guard_）Pcard-67164