Skip to content

【PIR OpTest Fix No.10】 fix test_row_conv_op #59636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 13, 2023
Merged

【PIR OpTest Fix No.10】 fix test_row_conv_op #59636

merged 5 commits into from
Dec 13, 2023

Conversation

xingmingyyj
Copy link
Contributor

PR types

Others

PR changes

Others

Description

PIR Op单测修复
修复单测 test_row_conv_op
修复后打开FLAGS_enable_pir_in_executor单测是否通过：否
报错信息：

File "/home/aistudio/fix_op/Paddle/build/test/legacy_test/op_test.py", line 2254, in _compare_list
"Output (" + name + ") has different lod at " + str(place),
AssertionError: Lists differ: [] != [[20, 30, 50]

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 3, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 3, 2023
@luotao1 luotao1 mentioned this pull request Dec 4, 2023
Closed
zyfncg
zyfncg reviewed Dec 5, 2023
View reviewed changes
paddle/phi/infermeta/binary.h Outdated
@@ -403,6 +403,16 @@ void RepeatInterleaveWithTensorIndexInferMeta(const MetaTensor& x,
const MetaTensor& repeats,
int dim,
MetaTensor* out);

void RowConvGradInferMeta(const MetaTensor& out_grad,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

反向InferMeta函数放到backward.h/cc中

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

paddle/phi/infermeta/binary.cc
"Input(Filter)'s shape: [%s].",
filter_dims));
out->set_dims(x.dims());
out->share_lod(x);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

设置下 dtype

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

kangguangli
kangguangli previously approved these changes Dec 6, 2023
View reviewed changes
@xingmingyyj xingmingyyj requested a review from zyfncg December 13, 2023 03:18
@kangguangli kangguangli merged commit fbce185 into PaddlePaddle:develop Dec 13, 2023
@xingmingyyj xingmingyyj deleted the fix_test_row_conv_op branch December 14, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyfncg zyfncg zyfncg approved these changes

@kangguangli kangguangli kangguangli approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xingmingyyj @zyfncg @kangguangli