Skip to content

【PIR API adaptor No.257、265】Migrate gcd，lcm into pir #59600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 11, 2023
Merged

【PIR API adaptor No.257、265】Migrate gcd，lcm into pir #59600

merged 7 commits into from
Dec 11, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Dec 1, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级 * #58067

No.257 paddle.Tensor.gcd
No.265 paddle.Tensor.lcm

因为lcm要使用gcd，故放一起。

将 paddle.Tensor.gcd 迁移升级至 pir，并更新单测 单测覆盖率：5/5
将 paddle.Tensor.lcm 迁移升级至 pir，并更新单测 单测覆盖率：5/5

@paddle-bot paddle-bot bot added the contributor External developers label Dec 1, 2023
@luotao1 luotao1 mentioned this pull request Dec 4, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 4, 2023
@enkilee
Copy link
Contributor Author

enkilee commented Dec 6, 2023 •
edited
Loading

@MarioLulab 改的这2个单测一直超时，不知为什么。

@MarioLulab
Copy link
Contributor

@MarioLulab 改的这2个单测一直超时，不知为什么。

收到，正在本地复现该问题，有进展了我及时在这个 pr 下面 comment ~

MarioLulab
MarioLulab reviewed Dec 7, 2023
View reviewed changes
@MarioLulab MarioLulab mentioned this pull request Dec 7, 2023
Closed
MarioLulab
MarioLulab approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0x45f
0x45f reviewed Dec 8, 2023
View reviewed changes
@0x45f 0x45f merged commit 257f5d3 into PaddlePaddle:develop Dec 11, 2023
@enkilee enkilee deleted the pir-api-265-257 branch December 14, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f left review comments

@Aurelius84 Aurelius84 Aurelius84 approved these changes

+1 more reviewer

@MarioLulab MarioLulab MarioLulab approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@luotao1 luotao1

@0x45f 0x45f

@YuanRisheng YuanRisheng

@MarioLulab MarioLulab

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enkilee @MarioLulab @Aurelius84 @0x45f @luotao1 @YuanRisheng