Skip to content

set_value in pir #59457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2023
Merged

set_value in pir #59457

merged 1 commit into from
Nov 29, 2023

Conversation

zoooo0820
Copy link
Contributor

@zoooo0820 zoooo0820 commented Nov 28, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

Pcard-66985

support _C_ops.set_value and _C_ops.set_value_with_tensor used in PIR mode. Since these two OP has been moved to PHI.

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jeff41404
jeff41404 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for doc

@jeff41404 jeff41404 merged commit 21b694b into PaddlePaddle:develop Nov 29, 2023
@zoooo0820 zoooo0820 deleted the set_value_in_pir branch November 29, 2023 09:13
@zoooo0820 zoooo0820 mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

@0x45f 0x45f 0x45f approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zoooo0820 @jeff41404 @0x45f @sunzhongkai588