Skip to content

[Cmake 治理] Move DDim etc. to common #59105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 77 commits into from
Dec 4, 2023
Merged

[Cmake 治理] Move DDim etc. to common #59105

merged 77 commits into from
Dec 4, 2023

Conversation

zhangboSJTU
Copy link
Contributor

@zhangboSJTU zhangboSJTU commented Nov 17, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

  • 将 pir 和 phi 以及 paddle 中的 DDim 都依赖 common 中的 DDim

Other

Pcard-67164

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 17, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhangboSJTU zhangboSJTU reopened this Nov 20, 2023
@zhangboSJTU zhangboSJTU force-pushed the decouple_ddim branch 2 times, most recently from 07567d9 to ae7643e Compare November 25, 2023 17:44
XieYunshen
XieYunshen previously approved these changes Dec 4, 2023
View reviewed changes
XieYunshen
XieYunshen previously approved these changes Dec 4, 2023
View reviewed changes
lanxianghit
lanxianghit previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aurelius84
Aurelius84 previously approved these changes Dec 4, 2023
View reviewed changes
xiaoguoguo626807
xiaoguoguo626807 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangboSJTU zhangboSJTU merged commit 36e262a into PaddlePaddle:develop Dec 4, 2023
SigureMo pushed a commit to gouzil/Paddle that referenced this pull request Dec 5, 2023
@zhangboSJTU @winter-wang @SigureMo
[Cmake 治理] Move DDim etc. to common (PaddlePaddle#59105)
528faed 
* fix conflict

* exception

* kunlun ci

* WIN_CI

* setup.py

* bug_fix

* hash

* auto_code_gen_WIN_CI

* inference_CI

* use_common_enforce

* delete pir_enforce

* delete_error

* change_cmake

* conflict

* cmake

* mac_CI

* inference_copy

* delete_pybind_common

* paddle_test

* split ddim constructor

* cc_test

* use cinn::common

* copy_infer

* delete_layer_test_new

* bug_fix

* infer

* fix inference bug

* conflict

---------

Co-authored-by: winter-wang <1030748926@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@chenwhql chenwhql chenwhql approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@risemeup1 risemeup1 risemeup1 approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 approved these changes

@XiaoguangHu01 XiaoguangHu01 Awaiting requested review from XiaoguangHu01 XiaoguangHu01 is a code owner

@lanxianghit lanxianghit Awaiting requested review from lanxianghit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.