Skip to content

【PIR API adaptor No.27、29、102 】 Migrate bmm/broadcast_tensors/histogram into pir #58833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2023
Merged

【PIR API adaptor No.27、29、102 】 Migrate bmm/broadcast_tensors/histogram into pir #58833

merged 3 commits into from
Nov 16, 2023

Conversation

DrRyanHuang
Copy link
Contributor

@DrRyanHuang DrRyanHuang commented Nov 8, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

AssertionError: TypeError not raised by test_type
  • histogram 单测 TestHistogramOpError.test_min_max_range_error 和 TestHistogramOpError.test_type_errors 未开启，单测覆盖率 6/8，二者单测中预期 raise TypeError, 但都抛出 InvalidArgumentError
  • bmm 单测全部通过

@luotao1 luotao1 mentioned this pull request Nov 9, 2023
Closed
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 10, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 10, 2023
@DrRyanHuang
Copy link
Contributor Author

@MarioLulab 打扰了🙏，麻烦帮我review下🙏🙏🙏

MarioLulab
MarioLulab approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 97b3447 into PaddlePaddle:develop Nov 16, 2023
@DrRyanHuang DrRyanHuang deleted the broadcast_tensors branch November 16, 2023 06:38
@DrRyanHuang DrRyanHuang mentioned this pull request Nov 21, 2023
Closed
21 tasks
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@DrRyanHuang @SecretXV
【PIR API adaptor No.27、29、102 】 Migrate bmm/broadcast_tensors/histogr…
1867c22 
…am into pir (PaddlePaddle#58833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

+1 more reviewer

@MarioLulab MarioLulab MarioLulab approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrRyanHuang @0x45f @MarioLulab