Skip to content

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Nov 9, 2023

PR types

Others

PR changes

APIs

Description

  • 新IR Python API适配升级 #58067
    No.154 将 paddle.Tensor.mode 迁移升级至 pir,并更新单测 单测覆盖率:7/10,其中单测 TestModeZeroError.test_errors 未覆盖到。

@paddle-bot paddle-bot bot added the contributor External developers label Nov 9, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 10, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
麻烦在 PR 描述里写一下 test_errors 单测未覆盖到,方便我们后续排查~

@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Nov 10, 2023

LGTM 麻烦在 PR 描述里写一下 test_errors 单测未覆盖到,方便我们后续排查~

Done

@0x45f 0x45f merged commit ec729e2 into PaddlePaddle:develop Nov 10, 2023
@ccsuzzh ccsuzzh deleted the mode branch November 13, 2023 06:57
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants