Skip to content

Conversation

Liyulingyue
Copy link
Contributor

PR types

Others

PR changes

Docs

Description

#58237 20

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

示例代码检查失败了,该 skip 的就skip吧

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunzhongkai588
Copy link
Contributor

从distributed 目录开始 __init__里面就没东西了,导致直接从 paddle 无法导入那之后的模块,从而 CI-Static-Check 报错。该 api 在 incubate 下,示例代码应该后续会由研发同学完善,CI-Static-Check 可暂时豁免

@luotao1 luotao1 merged commit 43a9fe0 into PaddlePaddle:develop Nov 17, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* Update dist_save.py

* Apply suggestions from code review

* Update dist_save.py

* Update python/paddle/incubate/distributed/utils/io/dist_save.py

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
@Liyulingyue Liyulingyue deleted the SM20 branch January 15, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants