Skip to content

Conversation

DrRyanHuang
Copy link
Contributor

@DrRyanHuang DrRyanHuang commented Nov 6, 2023

PR types

Others

PR changes

Others

Description

PIR API 推全升级

test_errors 会报错部分:

ERROR: test_errors (test_multi_dot_op.TestMultiDotOpError) 单测覆盖率 16/17
ERROR: test_errors (test_matrix_power_op.TestMatrixPowerAPIError) 单测覆盖率 28/29

test_matrix_rank_op 单测覆盖率 100%
test_mv_op 单测覆盖率 100%
test_qr_op 单测覆盖率 100%

@MarioLulab
Copy link
Contributor

麻烦在 PR 描述里补充单测的覆盖率 🚀

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work ~ ⭐
还有一处地方单测遗漏,麻烦补充一下吧

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants