【PIR API adaptor No.131】 Migrate paddle.Tensor.log2 into pir #58634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
MarioLulab
suggested changes
Nov 3, 2023
| @@ -3488,6 +3489,7 @@ def init_shape(self): | |||
|
|
|||
|
|
|||
| class TestLog2_Op_Int(unittest.TestCase): | |||
| @test_with_pir_api | |||
There was a problem hiding this comment.
这个单测并没有运行在静态图下，所以不需要 @test_with_pir_api 修饰
|
|
||
| @test_with_pir_api | ||
| def test_api(self): |
There was a problem hiding this comment.
此文件（test/legacy_test/test_activation_op.py） 的下面还有 被 create_test_act_fp16_class 与 create_test_act_bf16_class 创建的 fp16 与 bf16 单测，即 create_test_act_fp16_class(TestLog2) 和 create_test_act_bf16_class(TestLog2)。这些单测貌似没有打开 check_pir 开关，麻烦打开一下吧~
There was a problem hiding this comment.
btw, 在 test/legacy_test/test_op_name_conflict.py 文件的TestOpNameConflict，有一个运行在静态图下的单测，也使用 @test_with_pir_api 修饰一下吧
Closed
2c5d920 to
868d5a8
Compare
|
@MarioLulab 已按照要求修改，麻烦重新review，多谢~ |
0x45f
approved these changes
Nov 6, 2023
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
将 paddle.Tensor.log2 迁移升级至 pir，并更新单测
单测覆盖率：6/6
#58067