[NewExe] Performance optimization for program interpreter #58645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
From00
reviewed
Nov 6, 2023
| @@ -313,5 +313,47 @@ void Instruction::AddInplace(Variable* in, Variable* out) { | |||
|
|
|||
| void Instruction::ClearInplace() { vec_inplace_in_to_out_.clear(); } | |||
|
|
|||
| #if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP) | |||
| void Instruction::UpdataRecordStreamForGcInfo() { | |||
| bool is_interpreter_fast_gc_enabled = | |||
There was a problem hiding this comment.
这里为什么不直接调用IsInterpretercoreFastGCEnabled，而要把相关的判断逻辑代码拷贝一份？
There was a problem hiding this comment.
考虑到这个函数只是两个 flags 的判断，为了减少一个函数的调度，就直接在这里拷贝了一份逻辑
| // record stream for gc | ||
| #if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP) | ||
| bool need_record_stream_for_gc_ = false; | ||
| gpuStream_t record_stream_for_gc_; |
There was a problem hiding this comment.
record_stream_for_gc_命名比较拗口，且和函数名RecordStreamForGC容易混淆。这里需要存储在Instruction中的本质上是分配给该OP的运行stream，可否直接命名为stream？另外建议将其初始化为空。
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Nov 7, 2023
…le#58645) * fix * refine * refine * fix * fix * fix * fix
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
…le#58645) * fix * refine * refine * fix * fix * fix * fix
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…le#58645) * fix * refine * refine * fix * fix * fix * fix
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…le#58645) * fix * refine * refine * fix * fix * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Description
Performance optimization for program interpreter：静态化 CheckGC 的部分逻辑
Pcard-67164