Skip to content

Conversation

BeingGod
Copy link
Contributor

@BeingGod BeingGod commented Nov 1, 2023

PR types

Others

PR changes

Others

Description

  1. softplus 单测覆盖率:6/8
  2. softshrink 单测覆盖率:3/5
  3. softsign 单测覆盖率:3/5
  4. hardshrink 单测覆盖率:3/5
  5. hardtanh 单测覆盖率:3/4
  6. hardsigmoid 单测覆盖率:6/8
  7. hardswish 单测覆盖率:6/8

test_error 单测未支持

#58067

@paddle-bot paddle-bot bot added the contributor External developers label Nov 1, 2023
@Ligoml Ligoml changed the title [PIR API adaptor NO.97-100, 209-211] Migrate softplus/softsign/hardshrink/hardtanh/hardsigmoid/hardswish into pir 【PIR API adaptor NO.97-100、209-211】Migrate softplus/softsign/hardshrink/hardtanh/hardsigmoid/hardswish into pir Nov 2, 2023
@Ligoml Ligoml changed the title 【PIR API adaptor NO.97-100、209-211】Migrate softplus/softsign/hardshrink/hardtanh/hardsigmoid/hardswish into pir 【PIR API adaptor No.97-100、209-211】Migrate softplus/softsign/hardshrink/hardtanh/hardsigmoid/hardswish into pir Nov 2, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work ~ 但遗漏了部分 fp16 和 bf16 的单测,麻烦大佬添加一下吧 😃
可以顺便在 pr 描述里填写:test_error 单测未支持

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有一些问题🔧~

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 3, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f closed this Nov 6, 2023
@0x45f 0x45f reopened this Nov 6, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 58169ae into PaddlePaddle:develop Nov 6, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants