Skip to content

【PIR API adaptor No.219 、220】 Migrate pinv/svd into pir #58446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 23, 2023
Merged

【PIR API adaptor No.219 、220】 Migrate pinv/svd into pir #58446

merged 10 commits into from
Nov 23, 2023

Conversation

DrRyanHuang
Copy link
Contributor

@DrRyanHuang DrRyanHuang commented Oct 27, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

No.219 与 220
PIR API 推全升级

test_linalg_pinv_op

TestDivByZero.pinv_zero_input_static 不会 raise ValueError 于是关闭
LinalgPinvTestCase.test_grad 由于目前不支持 OpResult 进行 backward，故未开启

svd 全部通过

@paddle-bot
Copy link

paddle-bot bot commented Oct 27, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 27, 2023
@DrRyanHuang
Copy link
Contributor Author

DrRyanHuang commented Oct 28, 2023 •
edited
Loading

paddle/pir/math_op_patch.py 文件中

paddle.fill_constant 不存在, 需要等待 #58343 先merge (已merge)

@DrRyanHuang DrRyanHuang marked this pull request as draft October 28, 2023 07:03
@luotao1 luotao1 mentioned this pull request Oct 29, 2023
Closed
@zrr1999 zrr1999 mentioned this pull request Oct 31, 2023
Merged
@DrRyanHuang DrRyanHuang marked this pull request as ready for review October 31, 2023 10:04
@MarioLulab
Copy link
Contributor

LinalgPinvTestCase::test_static 单测出现的问题可以尝试一下：#58259 (comment)

原因可能是当前的 test_with_pir_api 中对 base.Program() 替换为 pir.Program 这一行为存在问题. 如果排查出是其他原因的话，欢迎子豪大佬在该 issue 里分享你的解决办法~

MarioLulab
MarioLulab reviewed Nov 1, 2023
View reviewed changes
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
MarioLulab
MarioLulab reviewed Nov 13, 2023
View reviewed changes
0x45f
0x45f reviewed Nov 14, 2023
View reviewed changes
@0x45f
Copy link
Contributor

0x45f commented Nov 20, 2023

这里报dtype的问题是因为EighInferMeta函数写的有问题，需要将EighInferMeta的最后一行修改为out_v->set_dtype(x.dtype());。 @MarioLulab 后面如果有类似dtype问题的话可以看下对应kernel的infermeta写的是否正确~

MarioLulab
MarioLulab approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f
Copy link
Contributor

0x45f commented Nov 21, 2023

代码冲突了，辛苦解决下冲突。另外请在pr描述中写一下pir单测打开了多少，LinalgPinvTestCase.test_grad这个单测是动态图的单测，不需要适配pir

@DrRyanHuang DrRyanHuang mentioned this pull request Nov 21, 2023
Closed
21 tasks
@0x45f 0x45f merged commit f2f48a5 into PaddlePaddle:develop Nov 23, 2023
@DrRyanHuang DrRyanHuang deleted the pinv_svd branch November 23, 2023 06:24
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@DrRyanHuang @SecretXV
【PIR API adaptor No.219 、220】 Migrate pinv/svd into pir (PaddlePaddle…
0b9b4f0 
…#58446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

+1 more reviewer

@MarioLulab MarioLulab MarioLulab approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrRyanHuang @MarioLulab @0x45f