[PIR]Perfect unittest for assign / softmax_mask_fuse_upper_triangle / tile / tril_triu / pad #58026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbo9674
approved these changes
Oct 16, 2023
zyfncg
reviewed
Oct 16, 2023
|
|
||
| def get_attr_repeat_times(list_repeat_times): | ||
| attrs_repeat_times = [] | ||
| for idx, times in enumerate(list_repeat_times): | ||
| if isinstance(times, Variable): | ||
| if isinstance(times, (Variable, paddle.pir.OpResult)): |
zyfncg
approved these changes
Oct 16, 2023
| @@ -288,6 +290,7 @@ def test_errors(self): | |||
| self.assertRaises(TypeError, paddle.assign, x2) | |||
| paddle.disable_static() | |||
|
|
|||
| @test_with_pir_api | |||
| def test_type_error(self): | |||
| paddle.enable_static() | |||
| with program_guard(Program(), Program()): | |||
There was a problem hiding this comment.
这个地方Program是base 引入的，可能还是旧的program, 可以检查一下
There was a problem hiding this comment.
这里应该是旧Program，下个pr重新修改一下这个单测
| @@ -275,6 +276,7 @@ def test_assign_bfp16(self): | |||
|
|
|||
|
|
|||
| class TestAssignOpErrorApi(unittest.TestCase): | |||
| @test_with_pir_api | |||
| def test_errors(self): | |||
| paddle.enable_static() | |||
| with program_guard(Program(), Program()): | |||
| @@ -105,6 +105,18 @@ def test_assign(self): | |||
| np.testing.assert_array_equal(fetched_x, self.value) | |||
| self.assertEqual(fetched_x.dtype, self.value.dtype) | |||
|
|
|||
| def test_pir_assign(self): | |||
| with paddle.pir_utils.IrGuard(): | |||
There was a problem hiding this comment.
在guard 中使用paddle.static.Program（） 便于后续静态图退场统一入口
| @@ -107,7 +111,7 @@ def test_static(self): | |||
|
|
|||
| exe = base.Executor(base.CUDAPlace(0)) | |||
| fetches = exe.run( | |||
| base.default_main_program(), | |||
| paddle.static.default_main_program(), | |||
There was a problem hiding this comment.
guard中是paddle.static.program(). 这里执行默认的program是同一个吗？
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
… tile / tril_triu / pad (PaddlePaddle#58026) * compact unittest * fix windows bugs * fix bugs * modify code * fix mkldnn
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
… tile / tril_triu / pad (PaddlePaddle#58026) * compact unittest * fix windows bugs * fix bugs * modify code * fix mkldnn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
补全如下算子的新IR单测，并解决单测验证中出现的问题：
assign / softmax_mask_fuse_upper_triangle / tile / tril_triu / pad