-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Hackathon 5th No.30】 为 Paddle 新增 vdot API #57800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
❌ The PR is not created using PR's template. You can refer to this Demo. |
@luotao1 @cyber-pioneer 你好, 代码风格检测和自动format,建议本地安装 pre-commit 2.17.0版本 |
Sorry to inform you that 4d0d0fa's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
请补充关于vdot求自动微分的测试 |
解决一下冲突,ci重新rerun一下,再看看 |
@cyber-pioneer 我已增加反向的梯度测试,但是反向op调用check_grad时,float64总是过不了精度的要求,我已检查梯度计算的代码应是正确的,请问我还可以从什么地方着手解决此问题呢? 另外,基于dot算子和vdot算子的相似性,我把test_dot_op.py中的DotOpBatch放大10倍(如下图所示),发现dot算子其实也有类似的问题,请问是不是开发团队默认接纳了此问题? |
从这里的描述来看,精度误差可能由dot引起,最好进一步深入定位一下dot精度异常的详细case以及原因(gpu&cpu,fp32/64, 前向/反向,shape, 不同平台算子实现的逻辑差异 等等) |
Sorry to inform you that 7bfb03a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
报错信息里看cpu的精度可能有问题,这种情况可以测试所有平台的case,如果gpu没问题可以合入,需要在PR描述里说明情况 |
建议可以简化一下vdot实现,在python层用其他算子组。单侧无法复用optest,可以自定义一个算子单侧,无需强制继承optest |
黑客松第5期已公示名单,感谢参与! |
PR types
New features
PR changes
APIs
Description
python/paddle/init.py
python/paddle/linalg.py
python/paddle/tensor/linalg.py
test/legacy_test/test_vdot_op.py
#57262