Skip to content

Conversation

megemini
Copy link
Contributor

@megemini megemini commented Sep 25, 2023

PR types

Others

PR changes

Others

Description

示例检查中使用 multiprocessing 会导致某些 paddle 中使用多进程的接口出现嵌套进程,因此增加 SOLO 指令,使用此指令的示例在主进程中运行检查。

涉及文件:

  • tools/sampcd_processor.py 增加 SOLO 指令
  • tools/test_sampcd_processor.py 增加测试用例
  • python/paddle/jit/api.py 临时文件,用于测试

p.s. convert-doctest 已同步修改

@SigureMo 请评审~

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo
Copy link
Member

python/paddle/jit/api.py 临时文件,用于测试

这次 CI 过了就不用恢复了,合入后我那边直接解决冲突就好~

@@ -500,6 +536,10 @@ def _extract_examples(self, api_name, docstring, **directives):
def _execute_xdoctest(
self, examples_to_test, examples_nocode, **directives
):
# if use solo(single process), execute without multiprocessing/thread
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外问一下 SOLO 是什么缩写呀?还是说 solo 这个单词?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

一般表示音乐里面的独奏 ~ 写那个 single processing 太长了,就想到这个 🤣

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一般表示音乐里面的独奏 ~ 写那个 single processing 太长了,就想到这个 🤣

好的~

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit 91bc283 into PaddlePaddle:develop Sep 26, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants